Uploaded image for project: 'Codehaus Cargo'
  1. Codehaus Cargo
  2. CARGO-727

WAR created by "uberwar" does not contain manifest

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.0.3
    • Component/s: Maven2/Maven3
    • Labels:
      None

      Description

      Obviously, it is impossible to "merge" manifests from source WARs.
      However, there is no possibility to specify own, even minimal, manifest for merged WAR file.

      I suggest to add this option to plugin configuration.
      For example,

      <plugin>
      <groupId>org.codehaus.cargo</groupId>
      <artifactId>cargo-maven2-plugin</artifactId>
      <extensions>true</extensions>
      <configuration>
      <descriptor>src/assemble/merge.xml</descriptor>
      <manifestEntries>
      <Implementation-Version>${majorVersion}</Implementation-Version>
      <Implementation-Vendor>MyCompany</Implementation-Vendor>
      </manifestEntries>
      </configuration>
      </plugin>
      

      From the code point of view:
      1) JarUtils.createJarFromDirectory():

      • use Manifest as additional parameter, map two-argument call to new function
      • when not null, pass Manifest as second argument to the constructor of JarOutputStream
        2) UberWarMojo/WarArchiveMerger/MergedWarArchive trio:
      • use configuration values to create correct Manifest object
      • send Manifest to JarUtil in MergedWarArchive.store()

        Gliffy Diagrams

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              antonkhitrenovich Anton Khitrenovich
              Reporter:
              antonkhitrenovich Anton Khitrenovich
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: