container.stop() doesn't always work in AbstractWarCapabilityContainerTestCase

Description

during tomcat4x testing, I found that a calls to container.stop() aren't safely handled.

getLocalContainer().start();
PingUtils.assertPingTrue(warPingURL.getPath()+" not started", warPingURL, getLogger());

getLocalContainer().stop();
PingUtils.assertPingFalse(warPingURL.getPath()+" not stopped", warPingURL, getLogger());

In this, since the stop() is not in a finally block, it may not be called, and then cause later tests to be unstable. Our tests must ensure that they clear resources upon shutdown. In junit, the best place to put these assurance is in the tearDown() method.

Please do so.

Status

Assignee

Adrian Cole

Reporter

Adrian Cole

Components

Fix versions

Affects versions

0.9

Priority

Major
Configure