Uploaded image for project: 'Codehaus Cargo'
  1. CARGO-1438

Only check / offset port numbers for configuration properties prefixed with "cargo."

    Details

    • Type: Improvement
    • Status: Closed (View workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects versions: None
    • Fix versions: 1.6.4
    • Components: Core
    • Labels:
      None

      Description

      See: https://groups.google.com/d/msgid/codehaus-cargo/CAKumxByRiQhKv8219N%2BwJEgDYqdNOWGMAHzNODqNQ0MtKCfKmA%40mail.gmail.com?utm_medium=email&utm_source=footer

      The Cargo port checker is useful as it checks whether ports are in use before starting a container - Which avoids dark issues later on. Unfortunately, in case a properties file is used for Cargo and for external services, Cargo can check port numbers outside its scope. For example, one could be defining one file with all port numbers:

      cargo.servlet.port=9888
      cargo.tomcat.ajp.port=9889
      cargo.rmi.port=9890
      
      spring.mail.host=localhost
      #comment out the port and the problem does not occur
      spring.mail.port=15025
      

      ... and Cargo will check the servlet, AJP and RMI ports (which is good), and the SMTP port (which doesn't name sense).

      Only check port numbers for configuration properties prefixed with cargo. to avoid this issue.

        Attachments

          Issue links

            Activity

              People

              • Assignee:
                alitokmen S. Ali Tokmen
                Reporter:
                alitokmen S. Ali Tokmen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: