Timeout in AbstractJsr88Deployer should be configurable

Description

In subclasses of AbstractJsr88Deployer, the timeout cannot be changed. When a large deployment over thin bandwidth takes longer than 2 minutes, following exception is raised:

1 2 3 4 5 6 7 8 Caused by: org.codehaus.cargo.util.CargoException: Deployment has timed out after 120000 milliseconds at org.codehaus.cargo.container.spi.deployer.AbstractJsr88Deployer.waitForProgressObject(AbstractJsr88Deployer.java:289) at org.codehaus.cargo.container.spi.deployer.AbstractJsr88Deployer.deploy(AbstractJsr88Deployer.java:123) at org.codehaus.cargo.maven2.DeployerDeployMojo.performDeployerActionOnSingleDeployable(DeployerDeployMojo.java:56) at org.codehaus.cargo.maven2.AbstractDeployerMojo.performDeployerActionOnAllDeployables(AbstractDeployerMojo.java:166) at org.codehaus.cargo.maven2.AbstractDeployerMojo.doExecute(AbstractDeployerMojo.java:97) at org.codehaus.cargo.maven2.AbstractCargoMojo.execute(AbstractCargoMojo.java:432) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)

It seems that the abstract base class was meant to make this configurable, but the method is private and can therefore not be overridden:

AbstractJsr88Deployer.java

1 2 3 4 private long getTimeout() { return 120000L; }

The method should be at least protected.

Status

Assignee

Savas Ali Tokmen

Reporter

Sebastian Paul

Components

Fix versions

Priority

Major
Configure