We're updating the issue view to help you get more done. 

AbstractTomcatManagerDeployer should throw an exception if the undeploy operation is called for a deployable which is not deployed

Description

Once the file was undeployed, undeploying again does not mean anything as there is no such application running . Cargo took cognizance of this when deploying repeatedly and throws TomcatManagerException saying that the application is already running . Is there any vision behind not throwing exception during repeated undeploy operation ?
Code evidence for no exception"
The reason was because they are not deliberately throwing exception and they are just logging(look at the "else" part )

1 2 3 4 5 6 7 8 9 10 11 12 13 14 try { TomcatDeployableStatus status = getTomcatManager().getStatus(getPath(deployable)); if (!status.equals(TomcatDeployableStatus.NOT_FOUND)) { performUndeploy(deployable); } else { getLogger().debug("Deployable [" + getPath(deployable) + "] already undeployed",this.getClass().getName()); } }

Status

Assignee

Savas Ali Tokmen

Reporter

Harish Kayarohanam

Components

Fix versions

Affects versions

1.3.1

Priority

Minor