Uploaded image for project: 'Codehaus Cargo'
  1. CARGO-1135

Allow direct configuration of SSL/TLS connector options for Tomcat 5.x, 6.x, and 7.x stand alone local configurations

    Details

    • Type: Improvement
    • Status: Closed (View workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects versions: None
    • Fix versions: 1.3.0
    • Components: Tomcat
    • Labels:
      None

      Description

      There are a number of configuration attributes on the "Connector" element in server.xml. For a stand alone local configuration, the ability to control the settings for the JSSE based implementation of SSL/TLS support would make testing against a secured Tomcat with Cargo far easier.

      The attached patch adds support for the configuration of the server key store, trust store, client authentication, and protocol settings.

      The patch adds 2 checkstyle violations relating to complexity; however, the metrics do not reflect the real-world simplicity of the method implementation and can be considered false positives.

      I did not see any integration tests that examine the resulting server.xml file and therefore did not include tests of the new features. I tested the updated code against the project I am working on. If there are automated tests of this aspect of the container support, please indicate where these reside and I will happily add the new features to the test.

      Finally, the documentation that enumerates the container configuration options is generated by the build. Is there anything specific that I need to do in the code base to ensure that the new options appear in the documentation?

        Attachments

          Activity

            People

            • Assignee:
              davidvaleri David Valeri (Inactive)
              Reporter:
              alitokmen S. Ali Tokmen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: