Allow jetty existing local container to start using only configuration on the server

Description

Existing local container should allow full configuration to be maintained in the server.

Currently implementation for Jetty, obligates to specify certain ports (or default are used).

Activity

Show:
Savas Ali Tokmen
March 16, 2012, 6:03 PM

Hi EduardoOK, I see your point now. You should I guess check whether RUNTIME_ARGS is not null and also whether it contains a --ini parameter Apart from that, it now looks fine to me. I guess we also need to modify the generateExistingConfigurationText method in the org.codehaus.cargo.documentation.ConfluenceContainerDocumentationGenerator to have an info describing how to use the existing settings with the existing Jetty standalone local configuration.What do you think?Cheers

Eduardo Horai
March 16, 2012, 7:55 PM

Totally agree... I've added
getConfiguration().getPropertyValue(GeneralPropertySet.RUNTIME_ARGS).contains("--ini=")because normally you can either specify --ini (if you don't want any ini file to be loaded) or --ini=foo.iniAnd I've added an explanation where you said... not sure if it's 100% correct.

Savas Ali Tokmen
March 17, 2012, 9:25 AM

Hi EduardoThis is looking very good now.As for the documentation, I think it needs a bit of tweaking; I can do that once you check your piece in, no worries.Cheers

Eduardo Horai
March 17, 2012, 11:15 AM

Just committed.

Savas Ali Tokmen
March 17, 2012, 2:09 PM

Perfect, I've also updated the documentation.If it looks good, you can close this issue and set the fix versions to 1.2.1 and 1.3.0.Thank you

Assignee

Eduardo Horai

Reporter

Eduardo Horai

Components

Fix versions

Priority

Major
Configure